-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use postcss.config.js when present #4411
Closed
Closed
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b205946
Add find-up to dependencies
kylemh 4dd6269
Use postcss config in webpack if config file present
kylemh 92538a7
Merge branch 'master' of github.com:storybooks/storybook
kylemh 5ea6161
Fix lockfile discrepancy
kylemh 9ab0c20
Merge branch 'master' into feature/use-custom-postcss-config
ndelangen 8703d83
Merge branch 'master' of github.com:storybooks/storybook into feature…
kylemh 3337585
Simplify and spread logic into separate file
kylemh 9250f1e
Restructure to include logging statement
kylemh 6f22d66
Fix config object
kylemh d413841
Asyncify findUp
kylemh d785ab3
Temporarily commit example
kylemh 7bac401
Merge branch 'master' of github.com:storybooks/storybook into feature…
kylemh dfa78c3
Actually use async
kylemh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import { logger } from '@storybook/node-logger'; | ||
import autoprefixer from 'autoprefixer'; | ||
import findUp from 'find-up'; | ||
|
||
export default function getStyleConfig(baseConfig) { | ||
// null if file is not found | ||
const customPostcssConfig = findUp.sync('postcss.config.js', { | ||
cwd: baseConfig.context, | ||
}); | ||
|
||
let postcssConfig = {}; | ||
if (customPostcssConfig) { | ||
logger.info('=> Using postcss.config.js'); | ||
postcssConfig = customPostcssConfig; | ||
} else { | ||
postcssConfig = { | ||
plugins: () => [ | ||
require('postcss-flexbugs-fixes'), // eslint-disable-line global-require | ||
autoprefixer({ | ||
flexbox: 'no-2009', | ||
}), | ||
], | ||
}; | ||
} | ||
|
||
return { | ||
test: /\.css$/, | ||
use: [ | ||
require.resolve('style-loader'), | ||
{ | ||
loader: require.resolve('css-loader'), | ||
options: { | ||
importLoaders: 1, | ||
}, | ||
}, | ||
{ | ||
loader: require.resolve('postcss-loader'), | ||
options: postcssConfig, | ||
}, | ||
], | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be very nice if you could asyncify this... Need to add some additional
await
s in the call chain though. Not critical one, bit since we already support async/await that be great =)