-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix - Addons relative path #9454
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/b3d6936uw |
Thanks @RuneKR! Can you add at least one test to |
Sure thing! :) |
Added test - Mocked the files so really only testing if MacOS is supported. I could create actual mock files, but that would then just test the OS on which the test is run anyway. Looked at current code and this example for my tests: 'https://jestjs.io/docs/en/manual-mocks' |
Closing this in favor of #9485, which I think is a simpler and more correct fix/test. Thanks so much for getting to the bottom of this!!! |
Issue: #9343
What I did
Editing the presets function to allow local addons to be included in main.js
How to test
Current function is not tested in existing unit tests as the function is only indirectly exposed.
Test the functionality by adding an addon to main.js like the following: