Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ghcr registry for hermes, bump version. #571

Merged
merged 1 commit into from
May 18, 2023
Merged

Use ghcr registry for hermes, bump version. #571

merged 1 commit into from
May 18, 2023

Conversation

DimitrisJim
Copy link
Contributor

Changes the registry to ghcr which hermes is now using and bumps the version.

@DimitrisJim DimitrisJim requested a review from a team as a code owner May 18, 2023 11:20
@DimitrisJim DimitrisJim requested a review from agouin May 18, 2023 11:20
@DimitrisJim
Copy link
Contributor Author

Some context on the force-push:

I originally opened the PR with hermes version set to 1.4.1, the most recently released version. It appears as if there's some issues with that, with the error logs showing:

failed to configure relayer r for chain chain-a: exit code 1:  The Hermes configuration file at path '/home/hermes/.hermes/config.toml' is invalid, reason: config error: path error: /home/hermes/.hermes/config.toml

Last time I bumped into this, while trying to configure hermes for some tests in ibc-go, the issue was some pesky uid/gid value that caused this file to not get moved into the correct place. My docker-foo isn't strong so why this has changed from 1.4.0 to 1.4.1 is a bit of a mystery to me.

Copy link
Member

@agouin agouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@agouin agouin merged commit 96edd24 into strangelove-ventures:main May 18, 2023
mergify bot pushed a commit that referenced this pull request May 18, 2023
(cherry picked from commit 96edd24)

# Conflicts:
#	relayer/hermes/hermes_relayer.go
mergify bot pushed a commit that referenced this pull request May 18, 2023
(cherry picked from commit 96edd24)

# Conflicts:
#	relayer/hermes/hermes_relayer.go
mergify bot pushed a commit that referenced this pull request May 18, 2023
(cherry picked from commit 96edd24)

# Conflicts:
#	relayer/hermes/hermes_relayer.go
mergify bot pushed a commit that referenced this pull request May 18, 2023
(cherry picked from commit 96edd24)

# Conflicts:
#	relayer/hermes/hermes_relayer.go
mergify bot pushed a commit that referenced this pull request May 18, 2023
@DimitrisJim DimitrisJim deleted the hermes_image branch May 18, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants