-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: support node_id values containing colons #3025
refactor: support node_id values containing colons #3025
Conversation
Thanks for adding the Here's a preview of the changelog: Add support for extra colons in the Before, the string Now we are using Here's the preview release card for twitter: Here's the tweet text:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3025 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 468 468
Lines 29112 29116 +4
Branches 3582 3582
=======================================
+ Hits 28104 28108 +4
Misses 827 827
Partials 181 181 |
CodSpeed Performance ReportMerging #3025 will not alter performanceComparing Summary
|
The node_id can be anything depending on how the user is handling it, so colons can appear in it, specially when it is some kind of encrypted value. This changes how we split the `GlobalID` string to only split the first colon in it, meaning that the remaining of the string will be considered as a whole for the node_id.
4cd67f3
to
bfc1f63
Compare
:yay: :D |
…l#3025) The node_id can be anything depending on how the user is handling it, so colons can appear in it, specially when it is some kind of encrypted value. This changes how we split the `GlobalID` string to only split the first colon in it, meaning that the remaining of the string will be considered as a whole for the node_id.
The node_id can be anything depending on how the user is handling it, so colons can appear in it, specially when it is some kind of encrypted value.
This changes how we split the
GlobalID
string to only split the first colon in it, meaning that the remaining of the string will be considered as a whole for the node_id.