-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add output file for export-schema
#3033
Conversation
Thanks for adding the Here's a preview of the changelog: Adds a new flag to Here's the preview release card for twitter: Here's the tweet text:
|
Hi, thanks for contributing to Strawberry 🍓! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of Release type: patch
Description of the changes, ideally with some examples, if adding a new feature. Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :) Here's the tweet text:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3033 +/- ##
==========================================
- Coverage 96.54% 96.54% -0.01%
==========================================
Files 468 468
Lines 29184 29197 +13
Branches 3589 3591 +2
==========================================
+ Hits 28177 28189 +12
Misses 827 827
- Partials 180 181 +1 |
e7e71d2
to
17aa9d7
Compare
CodSpeed Performance ReportMerging #3033 will not alter performanceFalling back to comparing Summary
|
770edbd
to
ddafcc6
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, I've left just a couple of minor comments 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
I've merged main here, I'll merge the PR once the tests are green 😊
Thanks for contributing to Strawberry! 🎉 You've been invited to join You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67 And don't forget to join our discord server: https://strawberry.rocks/discord 🔥 |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Patrick Arminio <[email protected]>
Description
See #3032 for motivation
Types of Changes
Issues Fixed or Closed by This PR
export-schema
#3032Checklist