Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use old clang when needed #79

Merged
merged 1 commit into from
Oct 21, 2022
Merged

CI: use old clang when needed #79

merged 1 commit into from
Oct 21, 2022

Conversation

astraw
Copy link
Member

@astraw astraw commented Oct 21, 2022

When building on macOS with old toolchain, we use an older version of XCode and clang.

Fixes #72.

@astraw
CI: use old clang when needed
d9c0daf 
When building on macOS with old toolchain, we use an older version of
XCode and clang.

Fixes strawlab#72.
Kijewski
Kijewski approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@Kijewski Kijewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for looking up how to install an older clang version for Mac + 1.38!

@Kijewski
Copy link
Collaborator

The failing Android cross-compile tests are unrelated to this PR.

@Kijewski Kijewski added the Tier-1 Rust Tier-1 platform label Oct 21, 2022
@Kijewski Kijewski merged commit 64edd66 into strawlab:main Oct 21, 2022
@astraw astraw deleted the mac-ci-uses-old-clang branch October 21, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kijewski Kijewski Kijewski approved these changes

Assignees
No one assigned
Labels
Tier-1 Rust Tier-1 platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI builds are broken on macOS with rust 1.38
2 participants
@astraw @Kijewski