Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please check out these commits and consider pulling them into your repository #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

oddlyzen
Copy link

@oddlyzen oddlyzen commented Nov 8, 2011

The commit messages (and commits themselves) should be fairly self-explanatory. Thanks for putting together 'mongo-resque'. It came in very handy in our environment!

Cheers,
Mark

Mark Coates added 4 commits October 25, 2011 22:02
…her than Resque.redis. Changed Resque.mongo to accept a String (which it instantiates as a Mongo::DB; update the exception error message to reflect the change.
…nature now looks like: Resque.enqueue(WelcomeEmail, 1, delay_until: (Time.now + 24.hours))
@dbackeus
Copy link

dbackeus commented Nov 9, 2011

Thanks for the pull request.

Was there any other need for the change of .mongo= other than for the -r flag to work properly?

I think I would prefer the database object wrapping to happen in bin/resque rather than change the API for setting the database as the semantics describing a mongo database location as a string is not well defined and might be misunderstood.

@oddlyzen
Copy link
Author

oddlyzen commented Nov 9, 2011

Nope, it was just because when I was testing out your fork, I found myself wanting to pass in the db name from the command line and when I tried, I got a type error. Personally, in the way that I am using this fork now, I no longer need the -r flag, so feel free to yank this commit. It had no bearing on the others, either, so it could be a clean break. Thanks again for maintaining this fork and If you need any help, I'd be happy to chip in. We are using mongo-resque in a production app that I'm working on here at Teladoc, so I'd be happy to be on the boat. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants