fix: fix lint issues in _server, client, and _settingsViewer

packages/_server/src/codeActions.ts

@@ -92,7 +92,7 @@ export function onCodeActionHandler(
             return action;
         }
 
-        async function genCodeActionsForSuggestions(dictionary: SpellingDictionary) {
+        async function genCodeActionsForSuggestions(_dictionary: SpellingDictionary) {
             const spellCheckerDiags = diagnostics.filter(diag => diag.source === Validator.diagSource);
             let diagWord: string | undefined;
             for (const diag of spellCheckerDiags) {

packages/_settingsViewer/package.json

@@ -9,6 +9,7 @@
     "build": "tsc -p . && webpack --env.production --config webpack.prod.js",
     "clean": "rimraf ../client/settingsViewer ./out",
     "coverage": "jest --coverage src",
+    "lint": "eslint 'src/**/*.ts'",
     "start:dev": "webpack-dev-server --config webpack.dev.js",
     "test": "jest src"
   },
@@ -36,6 +37,7 @@
     "@material/select": "^1.1.1",
     "@material/tab": "^1.1.1",
     "@material/tab-bar": "^1.1.1",
+    "@types/clone-deep": "^4.0.1",
     "@types/jest": "^24.9.0",
     "@types/node": "^11.15.4",
     "@types/react": "16.7.22",
@@ -46,8 +48,8 @@
     "@typescript-eslint/parser": "^2.19.0",
     "awesome-typescript-loader": "^5.2.1",
     "clean-webpack-plugin": "^3.0.0",
+    "clone-deep": "^4.0.1",
     "css-loader": "^3.4.2",
-    "deep-copy": "^1.4.2",
     "eslint": "^6.8.0",
     "extract-loader": "^3.1.0",
     "file-loader": "^4.3.0",
@@ -85,5 +87,6 @@
     "!**/*.map",
     "!**/*.test.*",
     "!**/*.spec.*"
-  ]
+  ],
+  "dependencies": {}
 }

packages/_settingsViewer/src/api/MessageBus.test.ts

@@ -6,7 +6,7 @@ import { sampleSettings } from '../test/samples/sampleSettings';
 describe('Validate MessageBus', () => {
     test('constructor', () => {
         const webviewApi: WebviewApi = {
-            postMessage: (msg: any) => webviewApi,
+            postMessage: (_msg: any) => webviewApi,
             onmessage: undefined,
         }
 
@@ -30,8 +30,8 @@ describe('Validate MessageBus', () => {
             postMessage: (msg: any) => loopBack(webviewApi, msg),
             onmessage: undefined,
         }
-        const onRequestConfigurationMessage = jest.fn((msg: RequestConfigurationMessage) => {});
-        const onConfigurationChangeMessage = jest.fn((msg: ConfigurationChangeMessage) => {});
+        const onRequestConfigurationMessage = jest.fn((_msg: RequestConfigurationMessage) => {});
+        const onConfigurationChangeMessage = jest.fn((_msg: ConfigurationChangeMessage) => {});
         const bus = new MessageBus(webviewApi);
         const listenerA = bus.listenFor("RequestConfigurationMessage", onRequestConfigurationMessage);
         const listenerB = bus.listenFor('ConfigurationChangeMessage', onConfigurationChangeMessage);
@@ -67,7 +67,7 @@ describe('Validate MessageBus', () => {
             postMessage: (msg: any) => loopBack(webviewApi, msg),
             onmessage: undefined,
         }
-        const bus = new MessageBus(webviewApi);
+        new MessageBus(webviewApi);
         expect(() => webviewApi.onmessage!({ data: {} })).not.toThrow();
     });
 });
@@ -77,4 +77,4 @@ function loopBack(webviewApi: WebviewApi, msg: any): WebviewApi {
         webviewApi.onmessage({ data: msg });
     }
     return webviewApi;
-}
+}

packages/_settingsViewer/src/api/message.test.ts

@@ -1,4 +1,14 @@
-import { isConfigurationChangeMessage, ConfigurationChangeMessage, isMessage, SelectFileMessage, isSelectFileMessage, SelectFolderMessage, isSelectFolderMessage, isEnableLanguageIdMessage, EnableLanguageIdMessage, EnableLocalMessage, isEnableLocalMessage } from './message';
+import {
+    isConfigurationChangeMessage,
+    ConfigurationChangeMessage,
+    isMessage,
+    SelectFileMessage,
+    isSelectFileMessage,
+    SelectFolderMessage,
+    isSelectFolderMessage,
+    EnableLocalMessage,
+    isEnableLocalMessage,
+} from './message';
 import { sampleSettings } from '../test/samples/sampleSettings';
 
 

packages/_settingsViewer/src/api/utils/Comparable.test.ts

@@ -53,7 +53,7 @@ describe('Validate Comparable', () => {
 });
 
 interface Sample {
-    id: number,
+    id: number;
     name: string;
     value: number;
     maybe: number | undefined;

packages/_settingsViewer/src/test/fixtures/AppState.ts

@@ -2,8 +2,8 @@ import { AppState } from '../../viewer/AppState';
 import { MessageBus, Message, isMessage } from '../../api';
 import { WebviewApi } from '../../api/WebviewApi';
 import { sampleSettings } from '../samples/sampleSettings';
-// import dcopy from 'deep-copy'; // Does not work because there isn't really a default.
-const dcopy: <T>(v: T)=>T = require('deep-copy');
+import dcopy = require('clone-deep');
+
 
 export class AppStateFixture extends AppState {
     _webviewApi: WebviewApi;

packages/_settingsViewer/src/viewer/AppState.test.ts

@@ -43,7 +43,7 @@ describe('Validate AppState', () => {
 
     test('actionSelectFolder', () => {
         const appState = getSampleAppState(sampleSettings);
-        const uri = 'file:///Users/cspell/projects/clones/ripgrep';
+        // const uri = 'file:///Users/cspell/projects/clones/ripgrep';
         const folderName = 'ripgrep';
         appState.actionSelectFolder(folderName);
         expect(appState.activeWorkspaceFolder).toBe(folderName);
@@ -63,7 +63,7 @@ describe('Validate AppState', () => {
 
     function getSampleAppState(settings: Settings): AppState {
         const webviewApi: WebviewApi = {
-            postMessage: (msg: any) => webviewApi,
+            postMessage: (_msg: any) => webviewApi,
             onmessage: undefined,
         };
         const msgBus = new MessageBus(webviewApi);

packages/_settingsViewer/src/viewer/AppState.ts

@@ -46,12 +46,12 @@ export interface State {
 }
 
 export interface FoundInConfig<T> {
-    value: Exclude<T, undefined>,
-    source: ConfigSource
+    value: Exclude<T, undefined>;
+    source: ConfigSource;
 }
 
 type InheritedFromSource<T> = {
-    value: Exclude<T, undefined>,
+    value: Exclude<T, undefined>;
     source: ConfigSource;
 }
 
@@ -166,7 +166,7 @@ export class AppState implements State {
         return workspace && workspace.textDocuments || [];
     }
 
-    @computed get documentSelection(): { label: string, value: string }[] {
+    @computed get documentSelection(): { label: string; value: string }[] {
         return this.documents.map(doc => ({ label: doc.fileName, value: doc.uri }));
     }
 
@@ -190,7 +190,7 @@ export class AppState implements State {
         this.debugMode = isEnabled;
     }
 
-    private isLocalEnabledEx(field: ConfigTarget, code: LocalId):InheritedFromSource<boolean> {
+    private isLocalEnabledEx(field: ConfigTarget, code: LocalId): InheritedFromSource<boolean> {
         const config = this.settings.configs[field];
         const source = config.inherited.locals || field;
         const locals = config.locals;
@@ -236,8 +236,6 @@ export class AppState implements State {
     }
 }
 
-function notUndefined<T>(a : T): a is Exclude<T, undefined> {
+function notUndefined<T>(a: T): a is Exclude<T, undefined> {
     return a !== undefined;
 }
-
-

packages/client/src/util/pipe.ts

@@ -12,6 +12,7 @@ export function extract<T, K extends keyof T, K2 extends NestedKey<T, K>, K3 ext
 export function extract<T, K extends keyof T, K2 extends NestedKey<T, K>, K3 extends NestedKey<Nested<T, K>, K2>, K4 extends NestedKey<Nested<Nested<T, K>, K2>, K3>>(key: K, k2: K2, k3: K3, k4: K4): (t: T | undefined) => Nested<Nested<Nested<T, K>, K2>, K3>[K4] | undefined;
 export function extract<T, K extends keyof T>(key: K): (t: T | undefined) => T[K] | undefined {
     if (arguments.length > 1) {
+        // eslint-disable-next-line prefer-rest-params
         const args = [...arguments];
         return (t: T | undefined) => {
             let v = t as any;
@@ -36,6 +37,7 @@ export function pipe<T, R, S, A, B>(t: T, fn: (t: T) => R, fn2: (t: R) => S, fn3
 export function pipe<T, R, S, A, B, C>(t: T, fn: (t: T) => R, fn2: (t: R) => S, fn3: (t: S) => A, fn4: (t: A) => B, fn5: (t: B) => C): C;
 export function pipe<T>(t: T): T {
     if (arguments.length > 1) {
+        // eslint-disable-next-line prefer-rest-params
         const fns = [...arguments].slice(1) as ((v: any) => any)[];
         let v = t as any;
         for (const fn of fns) {

packages/client/src/util/watcher.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const watch = require('node-watch');
 
 export type Events = 'update' | 'remove' | 'error';