Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2: Error on shutdown #1200

Closed
Jason3S opened this issue Aug 26, 2021 · 1 comment
Closed

V2: Error on shutdown #1200

Jason3S opened this issue Aug 26, 2021 · 1 comment
Milestone
v2

Comments

@Jason3S
Copy link
Collaborator

Jason3S commented Aug 26, 2021 •
edited
Loading 

Error: context (actionSuggestSpellingCorrections): Canceled: Canceled
    at Object.i [as canceled] (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:5:1157)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:89:8181
    at Array.forEach (<anonymous>)
    at h.dispose (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:89:8129)
    at P.terminate (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:94:684)
    at h (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:104:32088)
    at Socket.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:104:29731)
    at Socket.emit (events.js:327:22)
    at Pipe.<anonymous> (net.js:673:12)
    at Pipe.callbackTrampoline (internal/async_hooks.js:131:14)

Error: context (onError Handler showErrorMessage): Canceled: Canceled
    at Object.i [as canceled] (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:5:1157)
    at h._remoteCall (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:89:12893)
    at Proxy.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:89:9388)
    at T.showMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:85:205084)
    at Object.showErrorMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:94:29158)
    at onError (/Users/jason/projects/vscode-spell-checker/packages/client/src/util/errors.ts:12:30)
    at /Users/jason/projects/vscode-spell-checker/packages/client/src/util/errors.ts:55:16
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at _executeContributedCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:85:109243)
/Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-fork.js:5
@Jason3S Jason3S added this to the v2 milestone Aug 26, 2021
Jason3S added a commit that referenced this issue Aug 27, 2021
@Jason3S
fix: fix #1200
1fe023a 
Cause:
  `window.showInformationMessage` reject with `Canceled` during shutdown. This happens even though the message seemed to have gone away.

Two fixes:
1. Do not attempt to log or show a message if it was a canceled promise.
2. Do not log when showing VS Code UI.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@Jason3S