Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix #1200 #1202

Merged
merged 3 commits into from
Aug 27, 2021
Merged

fix: fix #1200 #1202

merged 3 commits into from
Aug 27, 2021

Conversation

Jason3S
Copy link
Collaborator

@Jason3S Jason3S commented Aug 27, 2021 •
edited
Loading

Cause:
window.showInformationMessage rejects with Canceled during shutdown. This happens even though the message seemed to have gone away.

Two fixes:

  1. Do not attempt to log or show a message if it was a canceled promise.
  2. Do not log when showing VS Code UI.

Jason3S added 3 commits August 27, 2021 08:34
@Jason3S
fix: fix #1200
1fe023a 
Cause:
  `window.showInformationMessage` reject with `Canceled` during shutdown. This happens even though the message seemed to have gone away.

Two fixes:
1. Do not attempt to log or show a message if it was a canceled promise.
2. Do not log when showing VS Code UI.
@Jason3S
Update errors.test.ts
2da1833
@Jason3S
test: improve code coverage
53c8a67
@Jason3S Jason3S merged commit 3bfe916 into main Aug 27, 2021
@Jason3S Jason3S deleted the dev-fix branch August 27, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jason3S