Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove words from [Work/Folder/Global] Dictionary command does not work. #1671

Closed
osaxma opened this issue Jan 12, 2022 · 1 comment · Fixed by #1672
Closed

Remove words from [Work/Folder/Global] Dictionary command does not work. #1671

osaxma opened this issue Jan 12, 2022 · 1 comment · Fixed by #1672

Comments

@osaxma
Copy link

osaxma commented Jan 12, 2022

Issue
Commands for removing words are not working properly. In fact, trying to remove a word that does not exist, will add the word to the dictionary.

Steps to reproduce:

  • In VS Code, run any of the following three commands

    Screen Shot 2022-01-12 at 4 01 25 PM
  • When prompted to insert the word, insert a word to be removed (e.g. someverywrongwordthatdoesnotexist).

  • If the word does exist, it'll do nothing.

  • If the word does not exist, it'll add it.

    • The Global command will add the word to "cSpell.userWords" on the global settings.json.
    • The other two commands will add the word to the working directory under .vscode/settings.json within cSpell.words.

Version

  • VS Code:
Version: 1.63.2
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:37:28.172Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 20.6.0
  • Spell: v2.1.3.

p.s. love the extension and how it's easily configurable 🙏🏽

@Jason3S Jason3S added this to the v2 - next milestone Jan 12, 2022
Jason3S added a commit that referenced this issue Jan 12, 2022
fix: #1671

- Add a fix
- Improve Unit Tests and coverage
Jason3S added a commit that referenced this issue Jan 12, 2022
fix: #1671

- Add a fix
- Improve Unit Tests and coverage
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants