Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"onDidChangeDiag" message in the console at each editor document switch. #1859

Closed
boltex opened this issue Mar 30, 2022 · 4 comments
Closed

Comments

@boltex
Copy link

boltex commented Mar 30, 2022

I'm developing an extension, which shows / changes the opened document in an editor. When running my extension through an extension host to test/debug it, at each change of shown file in the editor i get something outputting about "onDidChangeDiag" in the console like so:

image

I tracked it down to your extension... That didn't happen a little while ago. (git blame says Jason Dent added that 4 days ago). From vscode documentation, a onDidChangeDiagnostic event just means the status of the document has changed with regards to it's total estimated compilation/linting/checking related states.

Maybe you forgot to remove this console output?

console.error(`onDidChangeDiag ${new Date().toISOString()} %o`, e);

I just use vscode.workspace.openTextDocument on some opened editor with the opened file in preview mode to switch the viewed file. So it's not even a hack, and shouldn't be considered an error if onDidChangeDiagnostic triggers.... If I may suggest so...

Anyways, great product! You rock!

@boltex boltex changed the title "onDidChangeDiag" message in the console at each editor document switch when using extension hosts. "onDidChangeDiag" message in the console at each editor document switch. Mar 30, 2022
@Jason3S
Copy link
Collaborator

Jason3S commented Mar 30, 2022

@boltex,

Sorry about that. It was left over from a debugging session.

Jason3S added a commit that referenced this issue Mar 30, 2022
@Jason3S
Copy link
Collaborator

Jason3S commented Mar 30, 2022

@boltex,

I'll release a new version in a day or two. In the meantime, you can install it from here: Release v2.1.10 · streetsidesoftware/vscode-spell-checker

@Jason3S
Copy link
Collaborator

Jason3S commented Mar 30, 2022

@boltex,

I have released 2.1.11 to the VS Code marketplace.

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants