Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Spell Check Only Workspace Files isn't work as expected. #2192

Closed
icetbr opened this issue Sep 4, 2022 · 6 comments · Fixed by #2195 or #2189
Closed

Bug: Spell Check Only Workspace Files isn't work as expected. #2192

icetbr opened this issue Sep 4, 2022 · 6 comments · Fixed by #2195 or #2189

Comments

@icetbr
Copy link

icetbr commented Sep 4, 2022

A flag for this would be welcome. Thanks.
@Jason3S
Copy link
Collaborator

Jason3S commented Sep 4, 2022

@icetbr,

Please help me understand the issue. What are you trying to do?

  1. Ignore files that are not part of the workspace?
    image

  2. Ignore files that are in the workspace like: .vscode/settings.json

    image

  3. Something else.

@icetbr
Copy link
Author

icetbr commented Sep 4, 2022 •
edited
Loading

Hi, it's 1, but the flag doesn't do me any good!

~/.config/Code/User/settings.json

image

@Jason3S Jason3S changed the title Ignore files outside workspace, like settings.json Bug: Spell Check Only Workspace Files isn't work as expected. Sep 4, 2022
Jason3S added a commit that referenced this issue Sep 4, 2022
@Jason3S
fix: Update glob to match only files in workspace folders
8573776 
fix #2192
@Jason3S Jason3S mentioned this issue Sep 4, 2022
Merged
@icetbr
Copy link
Author

icetbr commented Sep 4, 2022

Is this equivalent? because it doesn't help either

image

@Jason3S
Copy link
Collaborator

Jason3S commented Sep 4, 2022

It should be "files": ["/**"],

Jason3S added a commit that referenced this issue Sep 4, 2022
@Jason3S
fix: Update glob to match only files in workspace folders (#2195)
9c89f2f 
fix #2192
@github-actions github-actions bot mentioned this issue Sep 4, 2022
Merged
@Jason3S
Copy link
Collaborator

Jason3S commented Sep 4, 2022

@icetbr,

I'll update the extension tomorrow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@icetbr @Jason3S