Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt VS Code's 'asWebviewUri' API #490

Closed
mjbvz opened this issue May 16, 2020 · 1 comment · Fixed by #548
Closed

Adopt VS Code's 'asWebviewUri' API #490

mjbvz opened this issue May 16, 2020 · 1 comment · Fixed by #548

Comments

@mjbvz
Copy link
Contributor

mjbvz commented May 16, 2020

Hi, I maintain VS Code's Webview API

Issue

Our telemetry suggests that your extension uses webviews and may be loading resources in these webviews using hardcoded vscode-resource: URIs. These URIs have some important limitations and don't work properly when VS Code is run in a browser. We are also making changes in the desktop version of VS Code that may cause these URIs to not work properly in future versions of VS Code.

While we are making our best effort to continue support existing webview extensions that use vscode-resource: URIs on desktop versions of VS Code, we will not able to fully support all uses cases.

Fix

To ensure that your extension continues to work in as many environments as possible—including on web and remotely—please:

These APIs shipped around 2 years ago so they should be available in all modern versions of VS Code. You can find additional information about the issue here: microsoft/vscode#97962

Let me know if you have any questions about this change

Jason3S added a commit that referenced this issue Sep 17, 2020
use `asWebviewUri` to generate the path to the `.js` file.
@Jason3S Jason3S mentioned this issue Sep 17, 2020
Jason3S added a commit that referenced this issue Sep 17, 2020
use `asWebviewUri` to generate the path to the `.js` file.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants