This repository has been archived by the owner on Nov 29, 2024. It is now read-only.
Fix #204: Have the consuming client refresh its metadata if the partition leadership changes. #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-wall
changed the title
k-wall
commented
Nov 27, 2022
showuon
reviewed
Dec 1, 2022
Comment on lines
+161
to
+169
| topicMetadata, err = ts.describeCanaryTopic() | ||
| if err != nil { | ||
| return result, err | ||
| } |
There was a problem hiding this comment.
I think this is a side bug fix, right? Before this change, we'll just return empty result even if the topic is created, which is unexpected.
There was a problem hiding this comment.
No, it is because I want topicMetadata to be populated in the case where the topic has just been created so that I can do ts.currentLeaders(topicMetadata) later on in the method.
There was a problem hiding this comment.
Is that worth a code comment?
|
I want to write unit tests to help with the refactoring. Please review #207 first. I can then build the unit tests on top of that. |
|
You are right. Thanks. |
ppatierno
approved these changes
Dec 6, 2022
PaulRMellor
approved these changes
Dec 6, 2022
…e partition leadership changes This minimises the time the canary spends consumer from followers after the partition leadership changes on the broker, and so avoid end to end latency measure being skewed. Signed-off-by: kwall <[email protected]>
|
Supporting unit test added. |
tombentley
approved these changes
Dec 8, 2022
Comment on lines
+161
to
+169
| topicMetadata, err = ts.describeCanaryTopic() | ||
| if err != nil { | ||
| return result, err | ||
| } |
There was a problem hiding this comment.
Is that worth a code comment?
Signed-off-by: kwall <[email protected]>
|
@tombentley comment added. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minimises the time the canary spends consuming from followers after the partition leadership changes on the cluster. This avoid the end to end latency measure being skewed by the additional latency introduced by the highwatermark propagation between leader/followers. I left a fuller explanation on this comment: #204 (comment)