Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to add retries on s390x tests failing #855

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

ppatierno
Copy link
Member

Travis CI s390x pipeline only seems to have a lot of flakyness with tests failing.
This PR adds some retries to make it more automatic (instead of me re-run jobs more and more times).

@ppatierno ppatierno added this to the 0.28.0 milestone Dec 13, 2023
@ppatierno ppatierno requested a review from Frawless December 13, 2023 08:26
Copy link
Member

@Frawless Frawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be great to put a note there and log an issue?

Signed-off-by: Paolo Patierno <[email protected]>
@ppatierno
Copy link
Member Author

Maybe it would be great to put a note there and log an issue?

I added a comment. Not sure a GitHub issue is really needed. The PR describes what is it for. We don't need to track it imho.

@ppatierno
Copy link
Member Author

@Frawless s390x failed as usual but I don't see any retry. Any idea?

@ppatierno
Copy link
Member Author

hey @nirmannarang because you were the first one who contributed to s390x in Travis CI, are you able to investigate why tests always keep failing only on this platform and not the others? There is flakyness only on s390x and not on all the other platforms. Thanks!

@ppatierno
Copy link
Member Author

@Frawless since this change, I tried to re-run the job more times and it's always green. What I see in the log is something like this:

[WARNING] Flakes: 
[WARNING] io.strimzi.kafka.bridge.http.ConsumerIT.receiveSimpleMessageTopicCreatedAfterAssignTest(VertxTestContext)
[ERROR]   Run 1: ConsumerIT.lambda$receiveSimpleMessageTopicCreatedAfterAssignTest$90:1787->lambda$receiveSimpleMessageTopicCreatedAfterAssignTest$89:1791 » IndexOutOfBounds Index 0 out of bounds for length 0
[INFO]   Run 2: PASS

I would assume the above test failed the first time (as usual) but passed the second time. So it seems the retry mechanism helps here.
While I would merge this, I still think that @nirmannarang should help on understanding while this test fails only on s390x architecture.

@Frawless wdyt?

@Frawless
Copy link
Member

@ppatierno exactly. Maybe 10 retries is a little bit more than we need, but as long as the tests takes several seconds it's fine from I guess.

I agree with you, from my POV there is some race in the code that is only visible on s390x.

@ppatierno ppatierno merged commit 2f56885 into strimzi:main Dec 13, 2023
12 checks passed
@ppatierno ppatierno deleted the travis-rerun-failing-s390x branch December 13, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants