-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to add retries on s390x tests failing #855
Conversation
Signed-off-by: Paolo Patierno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be great to put a note there and log an issue?
Signed-off-by: Paolo Patierno <[email protected]>
I added a comment. Not sure a GitHub issue is really needed. The PR describes what is it for. We don't need to track it imho. |
@Frawless s390x failed as usual but I don't see any retry. Any idea? |
hey @nirmannarang because you were the first one who contributed to s390x in Travis CI, are you able to investigate why tests always keep failing only on this platform and not the others? There is flakyness only on s390x and not on all the other platforms. Thanks! |
Signed-off-by: Paolo Patierno <[email protected]>
@Frawless since this change, I tried to re-run the job more times and it's always green. What I see in the log is something like this: [WARNING] Flakes:
[WARNING] io.strimzi.kafka.bridge.http.ConsumerIT.receiveSimpleMessageTopicCreatedAfterAssignTest(VertxTestContext)
[ERROR] Run 1: ConsumerIT.lambda$receiveSimpleMessageTopicCreatedAfterAssignTest$90:1787->lambda$receiveSimpleMessageTopicCreatedAfterAssignTest$89:1791 » IndexOutOfBounds Index 0 out of bounds for length 0
[INFO] Run 2: PASS I would assume the above test failed the first time (as usual) but passed the second time. So it seems the retry mechanism helps here. @Frawless wdyt? |
@ppatierno exactly. Maybe 10 retries is a little bit more than we need, but as long as the tests takes several seconds it's fine from I guess. I agree with you, from my POV there is some race in the code that is only visible on s390x. |
Travis CI s390x pipeline only seems to have a lot of flakyness with tests failing.
This PR adds some retries to make it more automatic (instead of me re-run jobs more and more times).