Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents crash when both url and enclosure_url dont exist #479

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

naps62
Copy link
Contributor

@naps62 naps62 commented Mar 29, 2018

this commit made the whole process fail when both url and enclosure_url do not exist. The reason is that entry.enclosure_url.present? throws an error, since the method doesn't exist at all

There's actually a much larger issue here, which is the error being silently hidden in FetchFeed, which just rescues every exception and flags the feed as red. This makes it very hard to debug errors

However I just fixed this one issue. I hope after re-deploying, my feeds will start working again, otherwise I'll have to get back at it

@naps62
Copy link
Contributor Author

naps62 commented Mar 29, 2018

FYI: just tested this on my running instance in Heroku. Previously, most feeds were not updating, due to a parsing error. After this fix, they started working (only one is still failing, I'll have to investigate that one later)

@swanson swanson requested a review from gabrielpoca March 30, 2018 00:02
@gabrielpoca gabrielpoca merged commit 2ac95a2 into stringer-rss:master Mar 30, 2018
@gabrielpoca
Copy link
Contributor

I also tested locally 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants