Prevents crash when both url and enclosure_url dont exist #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit made the whole process fail when both url and enclosure_url do not exist. The reason is that
entry.enclosure_url.present?
throws an error, since the method doesn't exist at allThere's actually a much larger issue here, which is the error being silently hidden in
FetchFeed
, which just rescues every exception and flags the feed as red. This makes it very hard to debug errorsHowever I just fixed this one issue. I hope after re-deploying, my feeds will start working again, otherwise I'll have to get back at it