Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes entry parse if there is no URL #480

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

naps62
Copy link
Contributor

@naps62 naps62 commented Mar 30, 2018

Parsing was failing if an entry had no defined URL. The parser was assuming it existed, and using it to expand all relative URLs

While it probably always exists for any well-made RSS feed, it won't be true if we're using something like Kill The Newsletter to convert emails to RSS

@gabrielpoca
Copy link
Contributor

@naps62 could you squash before I merge it?

@naps62
Copy link
Contributor Author

naps62 commented Mar 30, 2018

@gabrielpoca done

@gabrielpoca gabrielpoca merged commit 2c61134 into stringer-rss:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants