Fix encoding of nested parameters in multipart requests #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| + key + ".", null, null, null, 0, null | ||
| ); | ||
| } | ||
| multipartProcessor.addFileField(key, "blob", inputStream); |
There was a problem hiding this comment.
The two branches above are the same as before.
Only else branch below delegates the the flatten params used by createQuery in normal request method type
| + "Please check our API reference for the parameter type, " | ||
| + "or use the provided parameter class instead.", | ||
| value, keyPrefix), | ||
| keyPrefix, null, null, 0, null); |
There was a problem hiding this comment.
The error here could arise if:
- users pass file object to non-multipart request at any level.
- multi-part request params having nested file objects
There was a problem hiding this comment.
👍 Excellent, thanks for adding an explicit check and error.
| } | ||
|
|
||
| multipartProcessor = new MultipartProcessor(conn, boundary, ApiResource.CHARSET); | ||
| encodeMultipartParams(multipartProcessor, params); |
There was a problem hiding this comment.
Alternative design here is to have encodeParams as a method to multipartprocessor itself.
However, we still want to use the same flattenParams and LiveRequestGetter.Parameter within in class.
ob-stripe
approved these changes
Apr 10, 2019
| + "Please check our API reference for the parameter type, " | ||
| + "or use the provided parameter class instead.", | ||
| value, keyPrefix), | ||
| keyPrefix, null, null, 0, null); |
There was a problem hiding this comment.
👍 Excellent, thanks for adding an explicit check and error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc @remi-stripe @stripe/api-libraries