Use PHPStan in Travis CI #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
commented
Oct 30, 2019
|
Left one minor comment, but nice one! Love that it's catching problems already. ptal @ob-stripe |
remi-stripe
approved these changes
Oct 30, 2019
ob-stripe
force-pushed
the
ob-phpstan
branch
3 times, most recently
from
277575d to
81d6fce
Compare
|
Thanks again @nauxliu for getting the ball rolling with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries @nauxliu
Add support for PHPStan, a static analyzer for PHP.
Because PHPStan requires PHP 7.1 or more recent, we cannot add it as a dev dependency in
composer.json. I worked around this by setting up a Makefile to download PHPStan separately as a self-contained PHAR archive.PHPStan offers different analysis levels, from 0 (loosest) to 7 (strictest). Right now I've set it at 1 and fixed most issues it reported. We can increase it and fix more issues in future PRs.
There are two issues I could not fix without some refactoring, so what I did was create a baseline file, which is basically the PHPStan equivalent of the
.rubucop_todo.ymlfile. Thephpstan-baselinemake target can be used to regenerate the file.