Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare services for codegen #882

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe

Update services code to be closer to potential codegen output. This mainly means removing all of the allObjects, createObject etc. helper methods and calling request directly.

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nitpick but approving

lib/Service/AbstractService.php Show resolved Hide resolved
@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Feb 24, 2020
@ob-stripe ob-stripe merged commit 40d0a7a into integration-services Feb 25, 2020
@ob-stripe ob-stripe deleted the ob-services-prep-codegen branch February 25, 2020 00:49
@ob-stripe ob-stripe mentioned this pull request Feb 25, 2020
ob-stripe added a commit that referenced this pull request Feb 25, 2020
ob-stripe added a commit that referenced this pull request Feb 26, 2020
ob-stripe added a commit that referenced this pull request Feb 27, 2020
ob-stripe added a commit that referenced this pull request Mar 8, 2020
ob-stripe added a commit that referenced this pull request Mar 9, 2020
ob-stripe added a commit that referenced this pull request Mar 14, 2020
ob-stripe added a commit that referenced this pull request Mar 23, 2020
ob-stripe added a commit that referenced this pull request Mar 24, 2020
ob-stripe added a commit that referenced this pull request Apr 3, 2020
richardm-stripe pushed a commit that referenced this pull request Apr 24, 2020
ob-stripe added a commit that referenced this pull request May 1, 2020
richardm-stripe pushed a commit that referenced this pull request May 11, 2020
richardm-stripe pushed a commit that referenced this pull request May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants