-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check for existence of pass on paired watch #1219
Merged
charliecruzan-stripe
merged 13 commits into
master
from
charliecruzan/updatepushprovisioningforapplewatch-2
Dec 2, 2022
Merged
fix: check for existence of pass on paired watch #1219
charliecruzan-stripe
merged 13 commits into
master
from
charliecruzan/updatepushprovisioningforapplewatch-2
Dec 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
charliecruzan-stripe
force-pushed
the
charliecruzan/updatepushprovisioningforapplewatch-2
branch
from
December 2, 2022 00:10
84e29f3
to
afe48d0
Compare
charliecruzan-stripe
deleted the
charliecruzan/updatepushprovisioningforapplewatch-2
branch
December 2, 2022 14:43
Hi @charliecruzan-stripe
Thanks |
The SDK would check the paired devices for the payment pass, and wouldn't find any
Yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
canAddCardToWallet
now check specifically for the existence of passes that exist on paired device like apple watches if thehasPairedAppleWatch
bool is true. If a pass exists on only one of the device and its paired device, then the merchant should show the 'add to apple wallet' button. added new statuses to the enum for debugging/clarity.Motivation
Apple's guidelines around this have changed.
Testing
Documentation
Select one:
overrides #1162