Relax error message checks #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkey-patch npm-registry-client `request` method to include http status code in the error object. Modify `install` end-to-end tests to check 404 status code and ignore error message, because the message may differ between registry implementations.
|
LGTM |
bajtos
added a commit
that referenced
this pull request
Mar 24, 2014
…ecks Relax error message checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monkey-patch npm-registry-client
requestmethod to include http statuscode in the error object.
Modify
installend-to-end tests to check 404 status code and ignoreerror message, because the message may differ between registry
implementations.
Related discussion: rlidwka/sinopia#57
/to @rmg please review.