Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the skipped test cases after upgrading to [email protected] #389

Closed
jannyHou opened this issue Aug 28, 2018 · 5 comments
Closed

Fix the skipped test cases after upgrading to [email protected] #389

jannyHou opened this issue Aug 28, 2018 · 5 comments
Assignees
Labels

Comments

@jannyHou
Copy link
Contributor

jannyHou commented Aug 28, 2018

Description/Steps to reproduce

A follow up issue of #363
Fix the 2 skipped tests in datasource.test.js

Expected result

The 2 skipped tests pass

@dhmlau
Copy link
Member

dhmlau commented Oct 23, 2018

@jannyHou , after all the tests passed in generator-loopback, any outstanding tasks need to be done in order to release a semver-major version of loopback-cli to make use of the new generator-loopback?

@jannyHou
Copy link
Contributor Author

@dhmlau I would say this task shouldn't block the semver-major release of loopback-cli.

@bajtos
Copy link
Member

bajtos commented Feb 8, 2019

This task has been sitting in backlog for ~6 months by now and there was no problem (regression) caused by the fact that we are skipping some of the tests. Considering how little changes we are making in generator-loopback anyways, I am proposing to close this issue as "wontfix".

@jannyHou thoughts?

@jannyHou
Copy link
Contributor Author

I manually verified those two commands work on local, the time was spent on figuring out how to use yeoman-test functions(haven't found a good solution yet).
I am good to close it.

@dhmlau
Copy link
Member

dhmlau commented Feb 11, 2019

Closing per above comment.

@dhmlau dhmlau closed this as completed Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants