-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the skipped test cases after upgrading to [email protected] #389
Comments
@jannyHou , after all the tests passed in |
@dhmlau I would say this task shouldn't block the semver-major release of |
This task has been sitting in backlog for ~6 months by now and there was no problem (regression) caused by the fact that we are skipping some of the tests. Considering how little changes we are making in generator-loopback anyways, I am proposing to close this issue as "wontfix". @jannyHou thoughts? |
I manually verified those two commands work on local, the time was spent on figuring out how to use yeoman-test functions(haven't found a good solution yet). |
Closing per above comment. |
Description/Steps to reproduce
A follow up issue of #363
Fix the 2 skipped tests in
datasource.test.js
Expected result
The 2 skipped tests pass
The text was updated successfully, but these errors were encountered: