Struts 2.5 support #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix jstree tag : replace include "div-close" by </div> (s:div suppressed in Struts 2.5) - fix jstree theme loading for action url not in root context : use $.scriptPath (not sure if it's the good way) - fix missing require for scale and puff effects needing effect-size.js - replace all "id" attributes removed in Struts 2.5 by "var" in s:set and s:url tags, in JSPs and FTLs -> fix showcase and richtext editors - different fixes making showcase app work
- fix onComplete and onSuccess topics for <sj:tree tag
|
Thank you for taking care about this. |
|
Hi! I got some ideas to improve the tree tag. Jstree 3 now supports responsive theme and theme variant. We could add some attributes to the tag to support these features. Also jstree 3 come with useful plugins like search,... It would be great to enable and configure these plugins from the tag. Having a look at the code, and I think it could be fast and easy to implement it. |
|
@flofourcade sounds interesting. PR's are always welcome. ;-) |
|
Work already done on my fork, I update the jstree showcase to give an example then I submit a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<#include "/${parameters.templateDir}/simple/div-close.ftl" />by</div>(s:divsuppressed in Struts 2.5)
$.scriptPath (not sure if it's the good way)
and s:url tags, in JSPs and FTLs -> fix showcase and richtext editors
<sjt:tree />tag