-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue89fix #92
Issue89fix #92
Conversation
…e previous version)
…sion.js up so that jQuery.ui is defined
…i exists for the other javascripts. Also removed the locations where it would be loaded dynamicaly
…minified files for plugin javascripts from the git repository and adding them to the generation process in the pom
…r (add() instead of roll())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this issue.
@@ -56,3 +56,11 @@ src/main/resources/template/js/base/widget.min.js | |||
/src/main/resources/template/js/base/checkboxradio.min.js | |||
/src/main/resources/template/js/base/form-reset-mixin.min.js | |||
/src/main/resources/template/i18n/jquery-ui-timepicker-*.min.js | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you ignore this resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jogep
My mistake. i must have accidently ignored the full files instead of the minified versions.
I'll fix it ASAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jogep should be fixed now
@@ -23,6 +23,8 @@ | |||
<#assign jQueryVersion="2.2.4"> | |||
</#if> | |||
<#assign jQueryUIVersion="1.12.1"> | |||
<#-- issue89: temporary fix because of i18n files not being available for current jQuery UI version --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone know why 1.12.1 i18n resources are not available via google cdn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jogep
Personaly i don't have a clue, this was the only fix i could think of for now.
I didn't see any message by them saying where they're located either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ! I'll take care about the possible issue on datatables you've talked about soon.
@sdutry @flofourcade |
@jogep |
@jogep |
fixes #89
This pull request fixes several javascript problems, which, in most cases, were caused by the order in which they were loaded.
These problems were only happening with the following settings:
loadAtOnce="false"
loadFromGoogle="false"
I'd like someone else to merge this pull request. That way someone else will have looked at the code and might have spotted possible new bugs.