-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve API in a lambda #45
Conversation
49228d8
to
aa2c8b4
Compare
This solves some issues from #42 |
Overall looks solid. But I am going to rather bring someone from backend department to review it properly! |
hi @lucasconstantino I'm trying to access the playground but I get redirected to login (even if I grant access I still can't get there). If that's covered by your instructions then I don't get them I guess 😅 |
Hey @behalka! Are we exchanging reviews here, or what? 😆 So, you actually got a bug I'm really confused about. What's going on here is that this application is a SPA, so all paths are redirected to the root Now the confusing part: this issue seems to happen under specific browsers or contexts. For instance, I can actually access the playground if I use incognito mode in Chrome, or if I use Firefox 😱 Please, try to access it in Firefox or incognito, and report back to me if it does not work. I still don't know if it works only in my machine 🤔 Otherwise, I would recommend you clone the project to use it locally - which will trigger different server for the App and the API, meaning this issue won't occur. |
hey again @lucasconstantino - yeah it looks like that 😊 I got it working in the incognito mode so thanks a lot - also for the detailed explanation. I really appreciate that :) |
8cb5abe
to
c63096b
Compare
17dc0d2
to
60f82ef
Compare
c63096b
to
87df194
Compare
5a8fb4e
to
febb57b
Compare
febb57b
to
6171ba4
Compare
Resolves #44
This is an implementation of the GraphQL API as lambda, deployed inside Netlify's own lambda management system.
The working solution can be accessed in the following addresses:
App: https://deploy-preview-45--dep-manager-web.netlify.com/
GraphQL Playground: https://deploy-preview-45--dep-manager-web.netlify.com/.netlify/functions/playground (please, access in incognito)
About GraphQL Playground:
You MUST set a
GITHUB_OAUTH_TOKEN
header on the Playground UI. You can get a valid token either by authenticating in the App and copying theBida-App-Github-Token
localStorage key, or by getting a Personal Access Token on GitHub. If you do the second, please give the following permissions to the token:read:gpg_key
,read:org
,read:public_key
,read:repo_hook
,repo
,user