Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stylelint-config-recommended version #107

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Bump stylelint-config-recommended version #107

merged 1 commit into from
Mar 1, 2018

Conversation

hudochenkov
Copy link
Member

Fixes #106.

I think we could release patch update.

@jeddy3
Copy link
Member

jeddy3 commented Feb 28, 2018

When adding/installing this package I get [email protected] already:

$ yarn add stylelint-config-standard
yarn add v1.3.2
success Saved 2 new dependencies.
├─ [email protected]
└─ [email protected]

Is there something I'm missing here?

@ntwb
Copy link
Member

ntwb commented Feb 28, 2018

This is not required as @jeddy3 has pointed out stylelint-config-recommended version 2.1.0 is covered by the semantic version caret in ^2.0.0

@ntwb
Copy link
Member

ntwb commented Feb 28, 2018

Actually... I take that back, quoting the original report:

I see that you've updated to support stylelint 9, but still requires a dependency on stylelint-config-recommended 2.0.0, which has a dependency on stylelint < 8.
Should update dependency to stylelint-config-recommended 2.1.0

Technically stylelint-config-standard should require a minimum of version 2.1.0 of stylelint-config-recommended because it includes stylelint version 9.x changes that are not available in stylelint 8.x

@ntwb
Copy link
Member

ntwb commented Feb 28, 2018

A minor semver bump of stylelint-config-standard to version 18.2.0

@hudochenkov
Copy link
Member Author

Is there something I'm missing here?

There is a case, when stylelint@8, [email protected], and [email protected] were installed. User updates stylelint and stylelint-config-standard to the latest versions. stylelint-config-recommended won't be updated, because 2.0.0 is in range. But 2.0.0 doesn't say anything about stylelint@9 being peerDependency.

@jeddy3
Copy link
Member

jeddy3 commented Mar 1, 2018

Interesting. I hadn't considered that case. Thanks for taking the time to explain it.

I'll put out a minor release now.

@jeddy3 jeddy3 merged commit 6980d40 into master Mar 1, 2018
@jeddy3 jeddy3 deleted the issue-106 branch March 1, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants