Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run lint via npm test #262

Merged
merged 3 commits into from
Oct 2, 2022
Merged

Run lint via npm test #262

merged 3 commits into from
Oct 2, 2022

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Ref: stylelint/.github#12

Is there anything in the PR that needs further explanation?

This setting follows one of stylelint/stylelint.

@ybiquitous
Copy link
Member Author

Since linting is not intended to be executed on Node.js 12, the jobs on it fail. If stylelint/.github#12 is merged, we can merge this PR.

@ybiquitous ybiquitous mentioned this pull request Oct 1, 2022
Merged
jeddy3
jeddy3 approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Feel free to merge after merging the other PR.

Consistent lint & test behaviour across our repos will be good!

@ybiquitous
Copy link
Member Author

Retry of all jobs is successful!

@ybiquitous ybiquitous merged commit a8bb8fb into main Oct 2, 2022
@ybiquitous ybiquitous deleted the run-lint-via-npm-test branch October 2, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ybiquitous @jeddy3