Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opacity test can't pass #89

Closed
chemzqm opened this issue Apr 19, 2012 · 3 comments
Closed

Opacity test can't pass #89

chemzqm opened this issue Apr 19, 2012 · 3 comments

Comments

@chemzqm
Copy link

chemzqm commented Apr 19, 2012

When I run 'make test' there's an error showing that every opacity value get an unnecessary space in the end. To fix this, I removed args of opacity function in the file /lib/nib/verdor.styl. I'm not very sure about whether this argument is necessary and how to remove the space if we have to use it.

/*
 * Opacity with conditional IE support.
 */

opacity(n, args...)
  opacity: n args
  if support-for-ie
    filter: 'progid:DXImageTransform.Microsoft.Alpha(Opacity=%s)' % round(n * 100) args
@kizu
Copy link
Member

kizu commented Apr 19, 2012

That's not the opacity mixin's issue (args there are for !important support) and it's fixed in Stylus now.

@tj
Copy link
Collaborator

tj commented Apr 19, 2012

hmm yeah it seems someone committing was not running tests. I should be running them as well, my bad. I'll try and look into this soon

@kizu
Copy link
Member

kizu commented May 16, 2012

@visionmedia it seems that the version of the stylus in deps is rather old — https://github.com/visionmedia/nib/blob/master/package.json#L12 — so if you'd change the deps to the latest stylus, the problem would gone.

@tj tj closed this as completed in 8bb1e9e May 28, 2012
kizu pushed a commit to kizu/nib that referenced this issue May 28, 2012
Updated stylus dependency, fixes stylus#89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants