Send what features we support to the server. #279
Conversation
Some servers will listen to what features a client says it supports and will disable those features, returning "False" in the server capabilities reply. Which, in turn, disables that feature in our code.
Sometimes, a Windows pathname will be converted incorrectly. This is a bandaid fix on the problem. Previously, we would a path that started like this: \C:\Users\... When we tossed that path into Sublime, it would not be able to find the view associated to that file. This bandaid fix would remove the preceding \ in that pathname. This will mainly fix issues with diagnostics.
|
The server in question where I encountered this issue was https://github.com/OmniSharp/omnisharp-roslyn I'm not sure if sending everything in completionItemKind is correct or not. I figured I may as well. |
According to the LSP specifications, the processId field in the initialization params needs to be the parent process id. This is so the language server can shut itself down with the parent process terminates. This will fix bugs where when you close Sublime Text, the language server would be kept running.
plugin/core/main.py
Outdated
| } | ||
| "signatureHelp": { | ||
| "signatureInformation": { | ||
| "documentationFormat": ["plaintext"] |
There was a problem hiding this comment.
I'm fairly certain you can set this to markdown.
There was a problem hiding this comment.
I've added markdown to the list.
|
I’m eager to try this out tomorrow! |
…o send-supported-features
|
Whoops, I see the URI fix is also in here, could you keep that in the other PR? |
|
@tomv564 I thought I reverted my accidental merge. Is it still showing? |
|
It's likely I only saw the old commit and didn't check the diff - sorry to bother you. |
|
@LoneBoco do you happen to work with macOS? I tried several times to install the OmniSharp LSP server but never got it to work. |
|
@rwols I do not. I use omnisharp-roslyn in Windows. According to the README.md, you will need mono (>=5.2.0) to run it on OSX. You should be able to clone it and run These are the settings I use with LSP: One thing to note is that omnisharp-roslyn has issues with the current master branch. Some of them are partially fixed, but haven't been merged back yet. I've forked omnisharp-roslyn and pushed my own fixes for OmniSharp/omnisharp-roslyn#1113, OmniSharp/omnisharp-roslyn#1119, and OmniSharp/omnisharp-roslyn#1125. If you want the most problem free version of omnisharp-roslyn to mess with, I would recommend you clone from me for the time being. Also, I would recommend you run with logging enabled. I had originally tried to open a project and it didn't work. The logs showed that msbuild was not able to process the solution as the project was using .NET 4.7 and I didn't have that version installed on my machine. That might be a reason why you are having issues. |
Some servers will listen to what features a client says it supports and will disable those features, returning "False" in the server capabilities reply. Which, in turn, disables that feature in our code.