Feature/14 search #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed not necessary left joins from the count query as it isnt required in any way. |
TheJuki
reviewed
Nov 22, 2023
src/main/java/com/sublinks/sublinksapi/api/lemmy/v3/search/controllers/SearchController.java
Outdated
Show resolved
Hide resolved
TheJuki
reviewed
Nov 22, 2023
src/main/java/com/sublinks/sublinksapi/search/services/SearchService.java
Outdated
Show resolved
Hide resolved
TheJuki
reviewed
Nov 22, 2023
|
@TheJuki i never worked with the @Apiresponse i hope i did it right. |
jgrim
reviewed
Nov 23, 2023
| @@ -50,7 +50,22 @@ public String getPostMd5Hash(final Post post) { | |||
| } | |||
| } | |||
|
|
|||
| public Person getPostCreator(final Post post) { | |||
| public String getStringMd5Hash(final String post) { | |||
There was a problem hiding this comment.
Is this the same method I implemented just copied?
There was a problem hiding this comment.
If so we should move them both to a shared public utility
There was a problem hiding this comment.
The core logic is literally the same but i find it a bit overkill to require the WHOLE Post THEN just using the url.
jgrim
reviewed
Nov 23, 2023
src/main/java/com/sublinks/sublinksapi/search/repositories/CommentSearchRepository.java
Outdated
Show resolved
Hide resolved
jgrim
reviewed
Nov 23, 2023
src/main/java/com/sublinks/sublinksapi/search/repositories/CommunitySearchRepository.java
Outdated
Show resolved
Hide resolved
jgrim
reviewed
Nov 23, 2023
src/main/java/com/sublinks/sublinksapi/search/repositories/PostSearchRepository.java
Outdated
Show resolved
Hide resolved
jgrim
reviewed
Nov 23, 2023
jgrim
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Search capability.
Implemented /api/v3/search
Implemented New / Old Sorting
Implemented Pagination / Limit ( MAX 20 Lemmy default )
Implemented All/Post/Comment/Url/Community/User searches
closes #14