Use controller-runtime PriorityQueue #1061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 0.20.1 version includes a priority queue implementation so we can use that in lieu of our own. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
aswinsuryan,
dfarrell07,
maayanf24,
Oats87,
skitt,
sridhargaddam,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr1061/tpantelis/use_ctrl_rt_pq |
|
The unit test failures highlight that the priority work queue does not shut down as we expect and I've seen a code comment which indicates it's really designed to work with other components of controller-runtime so I think we should stay with what we have to be safe. |
|
🤖 Closed branches: [z_pr1061/tpantelis/use_ctrl_rt_pq] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 0.20.1 version includes a priority queue implementation so we can use that in lieu of our own.