Add custom VPC support in GCP #1060
Open
+44
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr1060/aswinsuryan/gcp-custom-vpc |
aswinsuryan
force-pushed
the
gcp-custom-vpc
branch
12 times, most recently
from
130eca6 to
46070f3
Compare
aswinsuryan
requested review from
mkolesnik,
Oats87,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
tpantelis
requested changes
Jan 7, 2025
pkg/gcp/gcp.go
Outdated
| } | ||
|
|
||
| // NewCloud creates a new api.Cloud instance which can prepare GCP for Submariner to be deployed on it. | ||
| func NewCloud(info CloudInfo) api.Cloud { | ||
| return &gcpCloud{CloudInfo: info} | ||
| func NewCloud(info *CloudInfo) api.Cloud { |
There was a problem hiding this comment.
I assume you changed this to a pointer to avoid a linter error re: the struct size but it's preferable to pass by value here since info is mutated. Ignore the linter error with //nolint...
aswinsuryan
force-pushed
the
gcp-custom-vpc
branch
2 times, most recently
from
c954a10 to
49dccb3
Compare
tpantelis
requested changes
Jan 8, 2025
pkg/gcp/ocpgwdeployer.go
Outdated
| @@ -36,19 +36,29 @@ import ( | |||
| ) | |||
|
|
|||
| type ocpGatewayDeployer struct { | |||
| CloudInfo | |||
| *CloudInfo | |||
There was a problem hiding this comment.
Suggested change
| *CloudInfo | |
| CloudInfo |
pkg/gcp/ocpgwdeployer.go
Outdated
| msDeployer ocp.MachineSetDeployer | ||
| instanceType string | ||
| image string | ||
| k8sClient k8s.Interface | ||
| } | ||
|
|
||
| // NewOcpGatewayDeployer returns a GatewayDeployer capable of deploying gateways using OCP. | ||
| func NewOcpGatewayDeployer(info CloudInfo, msDeployer ocp.MachineSetDeployer, instanceType, image string, | ||
| func NewOcpGatewayDeployer(info *CloudInfo, msDeployer ocp.MachineSetDeployer, instanceType, image string, |
There was a problem hiding this comment.
Suggested change
| func NewOcpGatewayDeployer(info *CloudInfo, msDeployer ocp.MachineSetDeployer, instanceType, image string, | |
| //nolint: gocritic // Ignore 'hugeParam' - pass by value for CloudInfo is intentional | |
| func NewOcpGatewayDeployer(info CloudInfo, msDeployer ocp.MachineSetDeployer, instanceType, image string, |
aswinsuryan
force-pushed
the
gcp-custom-vpc
branch
3 times, most recently
from
47d06fe to
971a03f
Compare
Signed-off-by: Aswin Suryanarayanan <[email protected]>
aswinsuryan
force-pushed
the
gcp-custom-vpc
branch
from
971a03f to
949190b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom VPC support in GCP