Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary CodeQL SARIF upload #2213

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Remove unnecessary CodeQL SARIF upload #2213

merged 3 commits into from
Aug 29, 2022

Conversation

dfarrell07
Copy link
Member

It seems the github/codeql-action/analyze GHA takes care of uploading
the SARIF so we don't need to do it ourselves.

Trying to do so fails with:

Error: Aborting upload: only one run of the codeql/analyze or
codeql/upload-sarif actions is allowed per job per tool/category.

Signed-off-by: Daniel Farrell [email protected]

@dfarrell07
Remove unnecessary CodeQL SARIF upload
6f7f61d 
It seems the github/codeql-action/analyze GHA takes care of uploading
the SARIF so we don't need to do it ourselves.

Trying to do so fails with:

  Error: Aborting upload: only one run of the codeql/analyze or
  codeql/upload-sarif actions is allowed per job per tool/category.

Signed-off-by: Daniel Farrell <[email protected]>
@dfarrell07 dfarrell07 self-assigned this Aug 26, 2022
@dfarrell07 dfarrell07 requested a review from mkolesnik as a code owner August 26, 2022 16:42
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2213/dfarrell07/no_codeql_sarif_ul
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@dfarrell07
Copy link
Member Author

E2E timed out, re-running.

   ✗ Pod "validate-clienttpdgb" is not running. (current state is Pending)
   • Checking Submariner support for the kube-proxy mode  ...
  
  Error: The operation was canceled.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Aug 29, 2022
@skitt skitt enabled auto-merge (rebase) August 29, 2022 07:34
@skitt skitt merged commit afecbec into submariner-io:devel Aug 29, 2022
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2213/dfarrell07/no_codeql_sarif_ul]

@dfarrell07
Copy link
Member Author

This fixed it, now passing.

https://github.com/submariner-io/submariner-operator/security/code-scanning?query=is%3Aopen+branch%3Adevel+tool%3ACodeQL
https://github.com/submariner-io/submariner-operator/runs/8071128453?check_suite_focus=true

@dfarrell07 dfarrell07 mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis approved these changes

@skitt skitt skitt approved these changes

@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees

@dfarrell07 dfarrell07

Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dfarrell07 @submariner-bot @skitt @tpantelis