Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add release-drafter to project #172

Merged
merged 2 commits into from
May 20, 2021
Merged

feature: Add release-drafter to project #172

merged 2 commits into from
May 20, 2021

Conversation

jack1902
Copy link

to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves:

Background

Adds release-drafter for consistent releases with snippets of what has recently been added based on PR titles

Changes

  • Add initial config for release-drafter

Testing

I've used this on my own projects and it is great for getting a release together over time

gchamon
gchamon reviewed May 17, 2021
View reviewed changes
.github/release-drafter.yml
Comment on lines +29 to +35
- label: 'enhancement'
branch:
- '/feature\/.+/'
body:
- '/feature{0,1}\/.+/'
title:
- '/feature/i'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to add label code-quality or something related when pushing from refactor/* branches

.github/release-drafter.yml Outdated
Comment on lines 7 to 8
- title: '🚀 Features'
label: 'feature'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by same here ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To also have support for code quality branches

@gchamon gchamon requested a review from a team May 17, 2021 23:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gchamon gchamon requested a review from agonbar May 20, 2021 12:38
agonbar
agonbar approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@agonbar agonbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@agonbar agonbar merged commit e3cf519 into subspacecommunity:master May 20, 2021
@jack1902 jack1902 deleted the feature/release-drafter branch May 20, 2021 14:32
agonbar pushed a commit that referenced this pull request Jun 3, 2021
Squashed commit of the following:
bf8db26 
commit 63f9ffe
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu Jun 3 09:40:48 2021 +0200

    docs: add gchamon as a contributor (#185)

    * docs: update README.md [skip ci]

    * docs: update .all-contributorsrc [skip ci]

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

commit f3f0c8e
Author: Gabriel Chamon Araujo <[email protected]>
Date:   Thu Jun 3 04:30:10 2021 -0300

    added option to disable dns in wireguard conf (#168)

    * added option to disable dns in wireguard conf

    * updated readme

    * adding suggested edits
    - adding example in both docker and docker-compose commands
    - changing disableDNS from string to bool
    - removing the DNS line altogether
    - disabling dnsmasq service if dns is disabled

commit e3cf519
Author: Jack <[email protected]>
Date:   Thu May 20 14:45:09 2021 +0100

    feature: Add release-drafter to project (#172)

    * Add release-drafter to project

    * Extend release-drafter for features and refactor

commit dda5a7e
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu May 20 14:18:05 2021 +0200

    docs: add Coffeeri as a contributor (#183)

    * docs: update README.md [skip ci]

    * docs: update .all-contributorsrc [skip ci]

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

commit fbd481c
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu May 20 14:06:09 2021 +0200

    docs: add Freekers as a contributor (#182)

    * docs: update README.md [skip ci]

    * docs: update .all-contributorsrc [skip ci]

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

commit 1ef43bc
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu May 20 14:03:14 2021 +0200

    docs: add dovreshef as a contributor (#181)

    * docs: update README.md [skip ci]

    * docs: update .all-contributorsrc [skip ci]

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

commit 6490762
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu May 20 14:02:21 2021 +0200

    docs: add miki725 as a contributor (#180)

    * docs: update README.md [skip ci]

    * docs: update .all-contributorsrc [skip ci]

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

commit 1e86175
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu May 20 14:01:28 2021 +0200

    docs: add d3473r as a contributor (#179)

    * docs: update README.md [skip ci]

    * docs: update .all-contributorsrc [skip ci]

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

commit 4f221ca
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu May 20 13:59:19 2021 +0200

    docs: add vojta7 as a contributor (#178)

    * docs: update README.md [skip ci]

    * docs: update .all-contributorsrc [skip ci]

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

commit 7bf0af9
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu May 20 13:57:51 2021 +0200

    docs: add SGudbrandsson as a contributor (#177)

    * docs: update README.md [skip ci]

    * docs: update .all-contributorsrc [skip ci]

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

commit 6570b64
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu May 20 13:48:43 2021 +0200

    docs: add sinanmohd as a contributor (#176)

    * docs: update README.md [skip ci]

    * docs: update .all-contributorsrc [skip ci]

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

commit 0fa7706
Author: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Date:   Thu May 20 13:47:27 2021 +0200

    docs: add nhamlh as a contributor (#175)

    * docs: update README.md [skip ci]

    * docs: update .all-contributorsrc [skip ci]

    Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchamon gchamon gchamon approved these changes

@agonbar agonbar agonbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack1902 @agonbar @gchamon