Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc stats and lists fixes #795

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Misc stats and lists fixes #795

merged 1 commit into from
Sep 30, 2019

Conversation

innatewonderer
Copy link
Collaborator

Fixes #794

Only display unique recent listens. I do too sometimes put my favorite song on loop, but I just don't want to be reminded at just how MANY times I listened to it :)

[Bug] To reproduce

If you actually have any of the files locally, listen to a song a bunch of times and observe before and after in /you_user -> Recently Listened To
Another way is to do it in RAILS_ENV=test rails s.

5.times do
   Listen.create(asset: asset, listener: user, track_owner: user)
end

sudara_s_Music___alonetone

Fullscreen_9_28_19__11_44_PM

"Ready For Review" checklist

  • PR title accurately summarizes changes
  • New tests were added for isolated methods or new endpoints
  • If this fixes a bug, "Fixes #XXX" is either the very first or very last line of the description.

Before code review and after additional commits during review.

  • Update title and description to account for additional changes
  • All tests green
  • Booted up the branch locally, exercised any new code
  • Percy changes are purposeful or explained
  • Css changes are happy on mobile (via Percy is ok)

… my favorite song on loop, but I just don't want to be reminded at just how MANY times I listened to it :)
@sudara
Copy link
Owner

sudara commented Sep 30, 2019

I like the idea of increasing signal, especially on the user's home page there. Unique makes sense there to me.

Hmmm, should we leave https://alonetone.com/sudara/history "intact" or also have it only show unique listens.

@ofsound Any negative consequences you can think of going "unique" here? I guess it means you can't tell who your 15 plays are from if you click through to the listeners on a track. Maybe the PR as is is perfect, sorta showing the "abridged" unique overview on home and full unabridged on /history.

#796 is tangentially related (better separation of self-listens).

@sudara sudara merged commit 8919050 into master Sep 30, 2019
@sudara sudara deleted the fix-stats branch September 30, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show duplicate listens on Recently Listened To
2 participants