Fixing singer module imports. #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @Shivansh-Khunger |
|
hey @Sumit-pd, I didn't saw it (apology for overseeing) now that I saw your PR there is a diff of polysynth creation. once your PR gets merged I can make one for the polysynth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem -
-> imports were made but there were no exports or the item didn't existed.
Changes -
-> added the export for the constants which were already there.
-> created a poly synthesizer and set its default state.
Questions -
-> I added the default state for the poly synthesizer acc to my ability & want to discuss the actual values.
@walterbender @meganindya plz have a look.