fix: hack fix to stop chord playing on widget close

sugarlabs · Feb 15, 2021 · 9211a0f · 9211a0f
1 parent bf67af5
commit 9211a0f
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/js/widgets/pitchstaircase.js b/js/widgets/pitchstaircase.js
@@ -351,6 +351,8 @@ class PitchStaircase {
      * @returns {void}
      */
     _playNext(index, next) {
+        if (this.closed) return;
+
         if (index === this.Stairs.length) {
             setTimeout(() => {
                 for (let i = 0; i < this.Stairs.length; i++) {
@@ -609,10 +611,12 @@ class PitchStaircase {
         widgetWindow.show();
         widgetWindow.onclose = () => {
             logo.synth.setMasterVolume(0);
-            logo.synth.stop();
+            this.closed = true;
             widgetWindow.destroy();
         };
 
+        this.closed = false;
+
         widgetWindow.addButton(
             "play-chord.svg",
             PitchStaircase.ICONSIZE,