Issue with Box and JA's "Hako"

[pikurasa]

There may be a somewhat major conflict with "box" (English project) loading in Japanese.

Test file:
Tonal Pitch Paint box and JA hako conflict.html.zip

Needs a bit more investigation, but is causing me problems at the moment.

[walterbender]

Can you please explain the steps you took to create this project?

[pikurasa]

0. Start MB
1. Change language to Japanese (tested in Kanji)
2. Open a project that uses "box" (tested "Pitch Paint")
3. "Box" blocks for project will still be in English, but "box" blocks in palette will be in Japanese.

At the moment, I am not experiencing the problematic behavior of not being able to copy any of the box blocks (in either language), which was making it impossible to find a workaround.

[pikurasa]

Most aspects of this issue have been resolved.

I tested with https://github.com/sugarlabs/musicblocks/files/4207147/Tonal.Pitch.Paint.box.and.JA.hako.conflict.html.zip

I did get a box with name "hako1" (see block at the right) when I opened the file, which is not recognized by MB. However, all the other blocks were called "hakonosuuchi1" (see box blocks at left that are attached) and they worked (I replaced the "hako1" block by hand).

I think the main issue has been resolved, but it may be wise to investigate why this shorter named (perhaps older?) block is being generated at all. I would hate for students in Japan to open some of these projects and they just do not work for them.

[walterbender]

I will investigate. But in the meantime, I found another bug.

It seems that number to pitch fails with float values. It works with integers.

[walterbender]

pushed a fix for the number to pitch bug :)

[walterbender]

I have looked at the project and cannot figure out how it was created. Most of the named blocks are stored internal as:
[15,["namedbox",{"value":"box1"}]

But one block is stored as:
[67,["namedbox",{"value":"箱１"}]

We translate the box name in the interface but the internal value is in English -- a special case for box1, box2, and box. I don't know how we can determine the intention of "箱１" when we encounter it other than to assume it is a different box.

[pikurasa]

I just remember switching to Japanese and reloading this project, but cannot remember the details. I do not think I explicitly named any box blocks.