Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request linter marked every variable as undefined in activity.js #2924

Closed
dflowcodes opened this issue Apr 20, 2021 · 3 comments
Closed

Pull Request linter marked every variable as undefined in activity.js #2924

dflowcodes opened this issue Apr 20, 2021 · 3 comments

Comments

@dflowcodes
Copy link

My partner and I made a recent PR to address issue #2907, but the changes failed because eslint marked every variable (there are a lot) in the activity.js file as undefined (which is not accurate). We have tested rather extensively and the changes do indeed fix the mentioned issue without affecting other functionality. The only changes were too the _afterdelete function. Could anyone help us understand what is triggering the errors so that we can get a valid pr?
@dflowcodes dflowcodes changed the title Pull Request linter marked every variable Pull Request linter marked every variable as undefined in activity.js Apr 20, 2021
@pikurasa
Copy link
Collaborator

@meganindya @walterbender have you looked into this yet?

It would be nice to fix this one bug. It is a bummer when projects are overwritten.

@walterbender
Copy link
Member

Please ignore the eslint errors in activity.js (and in blocks.js).

@walterbender
Copy link
Member

These lint errors were fixed in #2943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@walterbender @pikurasa @dflowcodes