Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some transport to blocks and totally remove playback #2358

Merged
merged 5 commits into from
Jun 18, 2020
Merged

Some transport to blocks and totally remove playback #2358

merged 5 commits into from
Jun 18, 2020

Conversation

meganindya
Copy link
Member

@meganindya meganindya commented Jun 18, 2020 •
edited
Loading

Improvement/fix:

  • reorganized and transformed the flow method in blocks/BoxesBlocks.js - class IncrementBlock

Transport to blocks:

  • _clearParameterBlocks as clearParameterBlocks
  • _updateParameterBlock as updateParameterBlock
  • _blockSetter as blockSetter
  • hideBlocks
  • showBlocks

Remove all playback related attributes:

  • playbackStatus, playbackPush
  • related variables
  • playback.js, playbackbox.js

@meganindya meganindya requested review from walterbender, aviral243, sksum and pikurasa and removed request for walterbender June 18, 2020 06:22
@meganindya
Copy link
Member Author

I had to touch a lot of execution specific areas. Although I've done some preliminary testing, this thing requires thorough testing, lest several things should behave abnormally later on.

@meganindya
Copy link
Member Author

meganindya commented Jun 18, 2020 •
edited
Loading

Tested with "remix-of-rainbow-connections" project. Imported, played, exported as HTML, Lilypond, ABC.

@walterbender
Copy link
Member

One small issue: the playbackForward code in js/widgets/temperament.js is not related to the playback function. The changes to that code should be reverted.

@meganindya
Copy link
Member Author

OK, thanks. I'll fix it.

@meganindya
Copy link
Member Author

Force-pushed the change.

@walterbender walterbender merged commit e98b2f9 into sugarlabs:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviral243 aviral243 Awaiting requested review from aviral243

@walterbender walterbender Awaiting requested review from walterbender

@sksum sksum Awaiting requested review from sksum

@pikurasa pikurasa Awaiting requested review from pikurasa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meganindya @walterbender