Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Wrap Block #2795

Merged
merged 7 commits into from
Feb 2, 2021
Merged

Feature: Wrap Block #2795

merged 7 commits into from
Feb 2, 2021

Conversation

ksraj123
Copy link
Member

Implements #2750

The block is made a clamp block to avoid ambiguity as the wrapping tendency is also affected by the turtle wrapping that could be set in the toolbar globally.

  • Basic functionality of wrap block,
    wrapping is on globally (from the toolbar) but if the wrapping is turned off in the wrap block then the statements within it don't wrap

    wrap_block_basic_functionality.mov
  • In the demonstration below, the horizontal rectangle is affected by global wrapping, vertical rectangle is affected by the settings of wrap block.

    wrap_block_global_wrap_on.mov
  • Wrap block inside fill
    Wrapping should not happen in the middle of fill, even if wrapping is turned on in the wrap block inside fill then wrapping does not happen

    global_on_local_on_wrap_inside_fill.mov
  • Nested Wrapping blocks

    nested_wrap_blocks.mov

@ksraj123 ksraj123 force-pushed the wrap-block branch 4 times, most recently from 0daf2cb to 819d6d5 Compare February 1, 2021 13:55
@ksraj123
Copy link
Member Author

ksraj123 commented Feb 2, 2021

@meganindya can you please have a look at this?. Thanks

@walterbender
Copy link
Member

The functionality is great. But there are several issues:
(1) The wrap block should be at the end of the palette, not the beginning of the palette
(2) When Wrap == On, a NO INPUT ARG error message appears on the screen. Not sure why.

@walterbender
Copy link
Member

Also, please create help artwork for the help block.

@ksraj123
Copy link
Member Author

ksraj123 commented Feb 2, 2021

@walterbender wrap block moved to the bottom of the palette, but I could not reproduce the with No INPUT ARG error message appearing when Wrap == on. Cloud you please provide some more details. Thanks

Kapture 2021-02-02 at 20 05 22

@walterbender
Copy link
Member

Here is what I am seeing:
Uploading Screenshot from 2021-02-02 10-15-35.png…

@walterbender walterbender merged commit 55c185a into sugarlabs:master Feb 2, 2021
@walterbender
Copy link
Member

We still need the help artwork... we can do that separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants