Souptik main #2884
Closed
Souptik main #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2021 18:52
…riable declarations
…tion declaration for widgets/musickeyboard.js
|
I am really sorry. I missed that there are 2 PR's working on these issues. I am immediately closing the request. Thank you very much for pointing that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have port the following changes,
Converted some var to let for blocks.js file following ES6 standards.
Converted function declaration within function with let/const function variable declarations in blocks.js file.
Converted callback functions to arrow functions as per ES6 standards in widgets/musickeyboard.js file.
Thank you.