Oscilloscope Widget: Enhancements to fullscreen mode #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2808
In the oscilloscope widget the graph takes up only a small portion of the screen in fullscreen mode and the extra space is not utilised in a meaningful manner. Even on zooming in, the graph zooms up over only the small portion of the screen taken up by the graph. Ideally, the graph should take up the total area available to the widget window in fullscreen mode. This would help us see the minute details in the graph easily.
Here is how it looks,
Before Changes
oscilloscope.enhancements.to.fullscreen.mode.needed.mov
After Changes
oscilloscope.enhancements.mov
Please share feedback and suggestions.