-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting rights via Argo is failing for some druids #2253
Comments
Seems like the DRO as passed to DSA (see HB alert) is not validating as a DRO per DSA OpenAPI spec: https://github.com/sul-dlss/dor-services-app/blob/master/openapi.yml#L968-L995 Check the JSON in the HB alert against the DRO schema. |
The problem I'm seeing is:
when the descriptive metadata is:
It works if you do:
so this might be a bug in the openapi parser gem. |
I've confirmed a bug in the committee gem: interagent/committee#286 |
In the meantime, I believe we can work around this by avoiding the use of all digits as an object title. |
It's possible to fix if we backed this change out: sul-dlss/cocina-models#144 |
It's not realistic to ask people to change titles. Note also there are examples that aren't all digits, like https://argo.stanford.edu/view/druid:yy778md9653 |
In the case of https://argo.stanford.edu/view/druid:yy778md9653 it looks like it's getting triggered on the non-sort character count, so actually the same bug. I think we have to revert sul-dlss/cocina-models#144 until interagent/committee#286 is resolved. {"note":[{"value":"4","type":"nonsorting character count"}]} |
Committee can't decide which type this is. See interagent/committee#286 Fixes sul-dlss/argo#2253 Ref sul-dlss/cocina-models#144
Committee can't decide which type this is. See interagent/committee#286 Fixes sul-dlss/argo#2253 Ref sul-dlss/cocina-models#144
Committee can't decide which type this is. See interagent/committee#286 Fixes sul-dlss/argo#2253 Ref sul-dlss/cocina-models#144
Committee can't decide which type this is. See interagent/committee#286 Fixes sul-dlss/argo#2253 Ref sul-dlss/cocina-models#144
Committee can't decide which type this is. See interagent/committee#286 Fixes sul-dlss/argo#2253 Ref sul-dlss/cocina-models#144 Ref sul-dlss/dor-services-app#1073
Describe the bug
A large number of druids hit errors when trying to change rights in Argo today. This happened using both the bulk update and the blue button methods to set rights.
This looks like a related HB error: there's a very long 400 message for the items that errored on rights today: https://app.honeybadger.io/projects/49894/faults/67600377
This does not appear to be affecting all druids, just some. I've looked for a pattern and the closest I've gotten is that many failed objects have brackets in the title. But not all failed objects have brackets.
User Impact
It's not possible to change rights for these items except via individual XML edits. With hundreds of druids to update, that's not a good workaround.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should be possible to change the rights
Additional context
It doesn't seem to matter which rights setting you choose. I've tried world, dark, stanford. There's a lot of metadata in the error message that isn't even rights, so maybe this is a Cocina problem somewhere else in the items?
The text was updated successfully, but these errors were encountered: