Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env configuration to the docs #547

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

alexander-schranz
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes -
Related issues/PRs -
License MIT

What's in this PR?

Add env configuration to the docs

Why?

To follow best practices for ES configuraition and to be consisten to the Sulu Article Recipe.

@niklasnatter
Copy link
Contributor

This configuration is already used in the receipt, right?
https://github.com/symfony/recipes-contrib/tree/master/sulu/article-bundle

@alexander-schranz
Copy link
Member Author

@nnatter yes but I would still documented it for this not using flex or had an error so flex was not run.

@alexander-schranz alexander-schranz added the DX Only affecting the end developer label Feb 16, 2021
@niklasnatter niklasnatter merged commit 1b8753c into 2.1 Feb 16, 2021
@niklasnatter
Copy link
Contributor

Sounds good 🙂

@alexander-schranz alexander-schranz deleted the enhancement/env-configuration branch February 16, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Only affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants