Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content fields to ArticleViewDocument #558

Merged
merged 4 commits into from
Apr 19, 2021

Conversation

Prokyonn
Copy link
Member

@Prokyonn Prokyonn commented Apr 16, 2021

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Adds an additional contentField to the ArticleViewDocument.
The contentField holds all properties, which are tagged with sulu.search.field in the xml configuration.

Thus the developer can easily index custom fields and use them e.g. in a SearchController.

Why?

Some projects need more data in the index to create a desired search behaviour.

Example Usage

        <property name="text" type="text_editor" mandatory="true">
            <meta>
                <title lang="en">Text</title>
                <title lang="de">Text</title>
            </meta>

            <tag name="sulu.search.field"/>
        </property>

To Do

  • Add tests
  • Add documentation page

@Prokyonn Prokyonn force-pushed the enhancement/es-indexing-1-2 branch 2 times, most recently from d532ca8 to 3a4bebe Compare April 16, 2021 14:28
@Prokyonn Prokyonn force-pushed the enhancement/es-indexing-1-2 branch from 3a4bebe to 23f4428 Compare April 18, 2021 21:26
@Prokyonn Prokyonn changed the title Add content fields to index Add content fields to ArticleViewDocument Apr 18, 2021
@wachterjohannes
Copy link
Member

@Prokyonn can you add a documentation section about this tag?

@Prokyonn Prokyonn force-pushed the enhancement/es-indexing-1-2 branch from b9f5232 to f21d3ef Compare April 19, 2021 05:37
@wachterjohannes wachterjohannes merged commit 5610e00 into sulu:1.2 Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants