Add own Website ContentController to render Content #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10159184588Details
💛 - Coveralls |
| * TODO this controller will later replace the DefaultController of the WebsiteBundle | ||
| * and should be base for all content controllers. | ||
| */ | ||
| class ContentController extends DefaultController |
There was a problem hiding this comment.
Not sure about the name:
- DefaultController (I personally find it to general)
- WebsiteController (already in the Website namespace)
- CmsController (we never used Cms in our code yet)
- TemplateController (controller should in future also handle JSON still it configured in a Sulu template, so still would be fine for me)
- ContentController
There was a problem hiding this comment.
ContentController sounds good for me
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
feature/introduce-content-controller
branch
from
f6faa64 to
8f8ab2e
Compare
Prokyonn
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think to already create a controller inside the ContentBundle. This should make upgrading projects easier later as we don't need to adjust the controllers in the .xml files.
Not sure about the name: