Update the PHPStan baseline #7117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
enhancement/phpstan-baseline-update-2023-07-06
branch
from
e72b18d to
3893dfc
Compare
alexander-schranz
force-pushed
the
enhancement/phpstan-baseline-update-2023-07-06
branch
from
3893dfc to
6833e04
Compare
Prokyonn
approved these changes
Jul 6, 2023
|
The failing tests are unrelated and hopefully will be fixed before the next doctrine/orm release. They not appear on stable versions. |
alexander-schranz
deleted the
enhancement/phpstan-baseline-update-2023-07-06
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Update the PHPStan baseline. https://github.com/phpstan/phpstan/releases/tag/1.10.25
Fix some issues, ignore the DOM errors as that seems to be stable enough and not worse tackling it.
Why?
Code quality.